Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The login with facebook buttons are not actionable on Hi5 #336

Closed
csasca opened this issue May 10, 2019 · 4 comments · Fixed by #344
Closed

The login with facebook buttons are not actionable on Hi5 #336

csasca opened this issue May 10, 2019 · 4 comments · Fixed by #344
Assignees
@maxxcrawford
Labels
P2 should fix before shipping v2.0.0 Issues related to major 2.X release

Comments

@csasca
Copy link

csasca commented May 10, 2019 •
edited

Affected versions:

  • Firefox 66.0.5

Affected Platforms:

  • Windows 7 x64
  • Windows 10 x64
  • Ubuntu 18.04 x64
  • macOS 10.13

Prerequisites:

Steps to reproduce:

  1. Go to Hi5.
  2. Click on either one of the two facebook login buttons.

Expected result:

  • A popup requesting the user to login with the facebook account will be shown.

Actual result:

  • Nothing happens.

Notes:

  • Please see the attached screenshot with the two facebook buttons:
    2019-05-08 17_22_51-hi5 - The social network for meeting new people
@maxxcrawford maxxcrawford self-assigned this May 10, 2019
maxxcrawford added a commit that referenced this issue May 10, 2019
@maxxcrawford
Removed console logs, fixed #336
d2b3e8d
@maxxcrawford maxxcrawford mentioned this issue May 10, 2019
Merged
@arthur-mozilla arthur-mozilla added the P2 should fix before shipping label May 10, 2019
@csasca
Copy link
Author

csasca commented May 13, 2019

Hi @maxxcrawford. We have a similar issue with this one on (https://uk.match.com/). By clicking on login, the "Continue with Facebook" will be greyed out completely, and by disabling the plugin, the button will have the correct behavior.

Will this be fixed too from this patch or should we log a new issue on this?

@maxxcrawford
Copy link
Contributor

@csasca A separate ticket please! It's easier to address each not supported website on a case-by-case basis. Thanks!

@obotisan
Copy link

We verified the fix on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13 by using FBC 1.7.1 and the bug is not reproducing anymore.
However, we found other two issue. They are logged: #354 and #353.

@hughpuppies
Copy link

My problem is that somehow when I used the facebook login with Hi5 when I signed up, stupid me I know been doing that for 4 and a half years, suddenly facebook decides too blaock my url login so now I can access my account. This is what I get when I try to use the facebook hi5 login. This URL Is Blocked: The URL "https://secure.hi5.com/f32ec7f84dd904" has been blocked from Facebook.

@maxxcrawford maxxcrawford added the v2.0.0 Issues related to major 2.X release label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

Labels
P2 should fix before shipping v2.0.0 Issues related to major 2.X release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Content Script Fixes (Adding Site Selector, Minor Changes) mozilla/contain-facebook
5 participants
@maxxcrawford @obotisan @arthur-mozilla @csasca @hughpuppies