SDK44: source-login-scripts.sh sourcing in the wrong shell #15723

zaubara · 2021-12-28T12:45:47Z

Summary

source-login-scripts.sh will fail silently and break every iOS build, when there is bash-specific code in one of the scripts sourced profiles.

Building an app for iOS will fail with:
Command PhaseScriptExecution failed with a nonzero exit code
or rather
PhaseScriptExecution [CP-User]\ Generate\ app.config\ for\ prebuilt\ Constants.manifest ... (in target 'EXConstants' from project 'Pods')

As it turns out, get-app-config-ios.sh will run source-login-scripts.sh, which will fail silently.
$current_shell will result in "bash", so, for me, ". ~/.bash_profile" will be run. This is, however, not running in bash - it's probably zsh for me.
So, if I would source my ~/.bash_profile in zsh with the same command manually, it will fail (for me) with:

. ~/.bash_profile
/usr/local/etc/bash_completion.d/subversion:30: command not found: shopt
/usr/local/etc/bash_completion.d/subversion:350: parse error near `<'

I suspect the same happening for the script. When removing the specific code from .bash_profile, everything works.

So the workaround for users will be removing the offending code (for me, that's commenting out homebrews bash completion), while the actual fix would have to be done in source-login-scripts.sh (see 8db2fac)

Managed or bare workflow? If you have `ios/` or `android/` directories in your project, the answer is bare!

bare

What platform(s) does this occur on?

iOS

SDK Version (managed workflow only)

No response

Environment

Expo CLI 5.0.3 environment info:
System:
OS: macOS 12.1
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.18.2 - ~/.nvm/versions/node/v14.18.2/bin/node
npm: 6.14.15 - ~/.nvm/versions/node/v14.18.2/bin/npm
Watchman: 2021.12.20.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK:
API Levels: 19, 21, 23, 25, 26, 27, 28, 29, 30
Build Tools: 23.0.1, 23.0.2, 25.0.2, 26.0.1, 26.0.2, 27.0.3, 28.0.2, 28.0.3, 29.0.2
System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom
Android NDK: 22.1.7171670
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7935034
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
npmPackages:
babel-preset-expo: 9.0.1 => 9.0.1
expo: ^44.0.2 => 44.0.2
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.3 => 0.64.3
react-native-web: 0.17.1 => 0.17.1
npmGlobalPackages:
eas-cli: 0.42.4
expo-cli: 5.0.3
Expo Workflow: bare

Reproducible demo

Have bash-specific code in ~/.bash_profile, like homebrews bash completion:

HOMEBREW_PREFIX=$(brew --prefix)
if type brew &>/dev/null; then
for COMPLETION in "$HOMEBREW_PREFIX"/etc/bash_completion.d/*
do
[[ -f $COMPLETION ]] && source "$COMPLETION"
done
if [[ -f ${HOMEBREW_PREFIX}/etc/profile.d/bash_completion.sh ]];
then
source "${HOMEBREW_PREFIX}/etc/profile.d/bash_completion.sh"
fi
fi

The text was updated successfully, but these errors were encountered:

DrNgo · 2021-12-31T17:45:44Z

This was also happening to me but I'm on a 2017 MacBook pro. My fix was to go into my bash_profile and comment out everything in it. It was able to build after that

0x079 · 2022-01-02T00:49:54Z

Had the same problem, had to migrate from bash to zsh and nuke everything in ~/.bash_profile

Kudo · 2022-01-03T01:29:30Z

hi there! please let me double confirm how did you build, by expo run:ios from shell or by Xcode?

zaubara · 2022-01-03T08:30:12Z

Hey @Kudo - thanks for dropping in!
I had the issue with both - running expo run:ios (in my zsh default console) and when building in Xcode.
($current_shell reporting as bash was from Xcode, I couldn't confirm that in zsh)

Kudo · 2022-01-03T14:41:27Z

thanks @zaubara. the call flow is expected to have $current_shell as bash because Xcode build phase script by default use bash. the unclear part for me is that even $current_shell is bash in your case, how would it run in zsh? could you help to clarify for this?

zaubara · 2022-01-04T15:26:34Z

Well, that's exactly the issue. ~/.bash_profile gets sourced, due to this:

else
   # Bash's setup script order is:
   #   /etc/profile (if it exists)
   #   The first of: ~/.bash_profile, ~/.bash_login, and ~/.profile
   # https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html

   if [ -f /etc/profile ]; then . /etc/profile; fi

   if [ -f ~/.bash_profile ]; then
      . ~/.bash_profile
   elif [ -f ~/.bash_login ]; then
      . ~/.bash_login
   elif [ -f ~/.profile ]; then
      . ~/.profile
   fi
fi

But this fails silently, if there's bash-specific code in any of those. I'm just suspecting them being run in zsh, because I can see an error when running it manually in zsh, and building works after removing the offending lines.

Kudo · 2022-01-04T15:49:41Z

yep, so i would like to know why it transit from bash to zsh. maybe you can verify with these serial commands and make sure the shell insist in bash:

$ ps -cp "$$" -o comm="" | sed s/^-//
bash

$ if [ -f /etc/profile ]; then . /etc/profile; fi
$ ps -cp "$$" -o comm="" | sed s/^-//
bash

$  if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi
$ ps -cp "$$" -o comm="" | sed s/^-//
bash

$  if [ -f ~/.bash_login ]; then . ~/.bash_login; fi
$ ps -cp "$$" -o comm="" | sed s/^-//
bash

$  if [ -f ~/.profile ]; then . ~/.profile; fi
$ ps -cp "$$" -o comm="" | sed s/^-//
bash

…ed (#15890) # Why fix #15809 fix #15723 # How suppress the errors from sourcing the `source-login-scripts.sh` # Test Plan ```sh $ echo 'this_is_an_invalid_command >> ~/.bash_profile $ expo run:ios ```

…ed (#15890) fix #15809 fix #15723 suppress the errors from sourcing the `source-login-scripts.sh` ```sh $ echo 'this_is_an_invalid_command >> ~/.bash_profile $ expo run:ios ```

Kudo · 2022-01-20T11:06:30Z

published expo-constants@13.0.1 with the fix. please upgrade and try again. thanks!

zaubara added the needs validation Issue needs to be validated label Dec 28, 2021

zaubara mentioned this issue Dec 28, 2021

Default Bare Workflow App Won't Build iOS on M1 Mac in SDK 44 #15665

Closed

okpalaChidiebere mentioned this issue Jan 11, 2022

no such module 'ExpoModulesCore' #15696

Closed

zaubara mentioned this issue Jan 12, 2022

[expo-constants][iOS] build failed: PhaseScriptExecution [CP-User]\ Generate\ app.config\ for\ prebuilt\ Constants.manifest #15809

Closed

Kudo mentioned this issue Jan 12, 2022

[constants][updates] Fix build errors when sourcing login script failed #15890

Merged

3 tasks

Kudo closed this as completed in #15890 Jan 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK44: source-login-scripts.sh sourcing in the wrong shell #15723

SDK44: source-login-scripts.sh sourcing in the wrong shell #15723

zaubara commented Dec 28, 2021

DrNgo commented Dec 31, 2021

0x079 commented Jan 2, 2022 •

edited

Kudo commented Jan 3, 2022

zaubara commented Jan 3, 2022 •

edited

Kudo commented Jan 3, 2022

zaubara commented Jan 4, 2022

Kudo commented Jan 4, 2022

Kudo commented Jan 20, 2022

SDK44: source-login-scripts.sh sourcing in the wrong shell #15723

SDK44: source-login-scripts.sh sourcing in the wrong shell #15723

Comments

zaubara commented Dec 28, 2021

Summary

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

What platform(s) does this occur on?

SDK Version (managed workflow only)

Environment

Reproducible demo

DrNgo commented Dec 31, 2021

0x079 commented Jan 2, 2022 • edited

Kudo commented Jan 3, 2022

zaubara commented Jan 3, 2022 • edited

Kudo commented Jan 3, 2022

zaubara commented Jan 4, 2022

Kudo commented Jan 4, 2022

Kudo commented Jan 20, 2022

Managed or bare workflow? If you have `ios/` or `android/` directories in your project, the answer is bare!

0x079 commented Jan 2, 2022 •

edited

zaubara commented Jan 3, 2022 •

edited