Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRITICAL] Login screen is without the login form #17735

Closed
siddhpant opened this issue May 24, 2019 · 9 comments
Closed

[CRITICAL] Login screen is without the login form #17735

siddhpant opened this issue May 24, 2019 · 9 comments
Labels
to-validate Old issues pending validation

Comments

@siddhpant
Copy link

siddhpant commented May 24, 2019 •
edited

I switched to the develop branch from master, and after due procedures when I proceed to login, there's no login form.

image

The console has this error:

Uncaught ReferenceError: io is not defined
    at Object.init (frappe-web.min.js:1)
    at frappe-web.min.js:1
    at frappe-web.min.js:1
    at Array.forEach (<anonymous>)
    at Object.trigger_ready (frappe-web.min.js:1)
    at HTMLDocument.<anonymous> (frappe-web.min.js:1)
    at HTMLDocument.dispatch (jquery.min.js:3)
    at HTMLDocument.r.handle (jquery.min.js:3)
    at Object.trigger (jquery.min.js:4)
    at HTMLDocument.<anonymous> (jquery.min.js:4)

Firefox screenshot:
image

The console shows the following error:

ReferenceError: io is not defined frappe-web.min.js:1:139691
    init http://localhost/assets/js/frappe-web.min.js:1
    Rollup http://localhost/assets/js/frappe-web.min.js:1
    trigger_ready http://localhost/assets/js/frappe-web.min.js:1
    forEach self-hosted:262
    trigger_ready http://localhost/assets/js/frappe-web.min.js:1
    Rollup http://localhost/assets/js/frappe-web.min.js:1
    jQuery 7
        dispatch
        handle
        trigger
        trigger
        each
        each
        trigger
    Rollup http://localhost/assets/js/frappe-web.min.js:1
    jQuery 4
        i
        fireWith
        ready
        J
@siddhpant siddhpant changed the title Login screen is without the login form [CRITICAL] Login screen is without the login form May 24, 2019
@siddhpant
Copy link
Author

Here's the apparent culprit:
image

@siddhpant
Copy link
Author

siddhpant commented May 24, 2019 •
edited

Changing io.connect to frappe.socketio.connect (type of which is used elsewhere in the code) fixes the problem for now, but please have a look at it.

@africlouds
Copy link

Is there a permanent solution? Having the same issue today

@ossplus
Copy link

ossplus commented Jun 11, 2019 •
edited

#17735 #16979 same issue.

@ossplus ossplus mentioned this issue Jun 11, 2019
Closed
@siddhpant
Copy link
Author

@africlouds Change it and save. That's permanent enough for now.

@rmehta
Copy link
Member

rmehta commented Jun 14, 2019

Please run bench build again.

@rmehta rmehta added the to-validate Old issues pending validation label Jun 14, 2019
@siddhpant
Copy link
Author

Ok

@siddhpant
Copy link
Author

Pulled the latest from branch, built. Issue resolved for me.

@africlouds , @gmplab please confirm so I can close this issue.

@siddhpant
Copy link
Author

Closing due to lack of confirmation.

@nwalke nwalke mentioned this issue Jul 21, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
to-validate Old issues pending validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rmehta @ossplus @africlouds @siddhpant